Description

That PR should fix case of loosing write-concern options while using timeoutMS option.
WriteConcern.fromOptions static method accepts 3 options formats:

• WriteConcernOptions object
• WriteConcern instance
• W type

But in case of using timeoutMS options, utils function resolveOptions calls (link to code) WriteConcern.fromOptions with options, which looks like WriteConcern instance, but there is no instance and more look like WriteConcernSettings type:

        writeConcern = WriteConcern.fromOptions({
          ...writeConcern,
          wtimeout: undefined,
          wtimeoutMS: undefined
        });

So that call return undefined as "parsing failed" and command losses write-concern context.

What is changing?

I changed options format to be consistent with WriteConcern.fromOptions type and use WriteConcernOptions format.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

It's a probably bug.

I used mongodb driver within mongoose and find out updateMany command with writeConcern and timeoutMS options does not pass write-concern context to CommanStartedEvent. This small fix should be helpful.

Release Highlight

WriteConcern omitted with timeoutMS is provided

When timeoutMS and a write concern were provided, the writeConcern was incorrectly omitted from the final command executed by the driver.

Thanks @stepanho for the contribution!

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Example: feat(NODE-1234)!: rewriting everything in coffeescript
• Changes are covered by tests
• New TODOs have a related JIRA ticket